Methyl heptane#19
Conversation
|
This includes changes to methyl decanoate, and a lot of fix up commits. Please could you interactive rebase to tidy it up? Thanks Zil |
|
Yeah sure I'm working on it at the moment |
|
Is this PR ready for review? @nateharms @ajuluc |
|
Yep |
bryanwweber
left a comment
bryanwweber
left a comment
There was a problem hiding this comment.
Thank you for submitting this data! There seem to be a few problems with it, can you address the comments below? Thank you!
| @@ -0,0 +1,148 @@ | |||
| --- | |||
| file-authors: | |||
| - name: Nathan Harms | |||
There was a problem hiding this comment.
The indentation should be 2 spaces for YAML files
| - name: Nathan Harms | ||
| ORCID: 0000-0003-2680-371X | ||
| file-version: 0 | ||
| chemked-version: 0.0.1 |
There was a problem hiding this comment.
chemked-version should be 0.4.1 if these files are compatible with that version (if they're not, they should be made to be).
| - temperature: | ||
| - 703.0 kelvin | ||
| ignition-delay: | ||
| - 47.0 us |
There was a problem hiding this comment.
Looks like the ignition delay is the same as the first data point (its also the same for all the points in this file and a few others). Can you please check this?
| composition: *comp | ||
| ignition-type: *ign | ||
| equivalence-ratio: 0.5 | ||
|
No newline at end of file |
There was a problem hiding this comment.
Please make sure to end the file with a newline. Editors such as Atom and VSCode can be configured to add this automatically 😄
| ignition-delay: | ||
| - 47.0 us | ||
| - uncertainty-type: relative | ||
| uncertainty: 0.2 |
There was a problem hiding this comment.
Is the uncertainty really 20%? Seems high, but if its from the paper, that's fine.
| datapoints: | ||
| - temperature: | ||
| - 373.0 kelvin | ||
| compressed_temperature: |
There was a problem hiding this comment.
I believe we have a new(er) rcm-data field, see https://pr-omethe-us.github.io/PyKED/schema-docs.html#ignition-rcm-data All the RCM-specific data should go in that field
| composition: *comp | ||
| ignition-type: *ign | ||
| equivalence-ratio: 0.5 | ||
|
No newline at end of file |
| composition: *comp | ||
| ignition-type: *ign | ||
| equivalence-ratio: 1.0 | ||
|
No newline at end of file |
| - temperature: | ||
| - 678.0 kelvin | ||
| ignition-delay: | ||
| - 47.0 us |
There was a problem hiding this comment.
This file also has all 47.0 us as the ignition delay
| - temperature: | ||
| - 692.0 kelvin | ||
| ignition-delay: | ||
| - 47.0 us |
There was a problem hiding this comment.
This file is also all 47.0 us as the ignition delay
4 participants
No description provided.